Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the linting offenses and run it on CI successfully #895

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Fix the linting offenses and run it on CI successfully #895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b14f674
Test with Ubuntu 20 for supported CI runners
mkllnk Sep 22, 2023
9e38fa0
Remove old Datadog code offending linting checks
mkllnk Sep 25, 2023
ba655d1
Add change condition on for linting
mkllnk Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/deploy/tasks/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"
args:
chdir: "{{ build_path }}"
creates: "{{ build_path }}/.bundle/config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this interestingly named argument. I would have expected more generic "if" style code, which I thought ansible also supports.

All good, this is clearly the standard way to do it, it's just new to me.

become: true
become_user: "{{ app_user }}"

Expand Down
Loading