Fix the linting offenses and run it on CI successfully #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github doesn't have Ubuntu 18 runners any more.
We actually know that the file is not there because we just created a new build directory but it's good style to add these things.
dacook
approved these changes
Sep 26, 2023
| @@ -64,6 +64,7 @@ | |||
| " | |||
| args: | |||
| chdir: "{{ build_path }}" | |||
| creates: "{{ build_path }}/.bundle/config" | |||
There was a problem hiding this comment.
TIL about this interestingly named argument. I would have expected more generic "if" style code, which I thought ansible also supports.
All good, this is clearly the standard way to do it, it's just new to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two CI checks. The build is still broken but the linting should work now.