Fix logQ(P) estimation used for finding the minimum ring dimension #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yspolyakov
commented
Jun 10, 2024
•
yspolyakov
commented
- Added EstimateLogP and EstimateMultipartyFloodingLogQ
- Updated the logic for BGV, BFV, and CKKS to use these methods prior to checking (finding) the ring dimension based on the LWE security tables
yspolyakov
changed the title
|
|
||
| while (nRLWE(logqCeil) > n) { | ||
| n = 2 * n; | ||
| logq = logqBFV(n); | ||
| k = static_cast<int32_t>(std::ceil((std::ceil(logq / std::log(2)) + 1.0) / dcrtBits)); | ||
| logqCeil = k * dcrtBits * std::log(2); |
There was a problem hiding this comment.
Not adding the +1 anymore? The same comment for the occurrences below.
There was a problem hiding this comment.
I don't see why + 1 is needed in the current version of OpenFHE. Maybe in an old version (of PALISADE), we sometimes had larger moduli (NextPrime might have been used). So in my mind, ceil(logq/dcrtBits) is sufficient and guarantees that that logq<=k*dcrtBits. Moreover, adding + 1 would cause problems in the new estimation logic (getting an extra RNS limb when it is not needed).
added 6 commits
June 10, 2024 21:36
andreea-alexandru
approved these changes
Jun 11, 2024
dsuponitskiy
force-pushed
the
issue-774
branch
2 times, most recently
from
705bc25
to
78b6cd4
Compare
pascoec
reviewed
Jun 11, 2024
pascoec
reviewed
Jun 11, 2024
pascoec
reviewed
Jun 11, 2024
| // Find number and size of individual special primes. | ||
| uint32_t maxBits = moduliPartQ[0].GetLengthForBase(2); | ||
| for (usint j = 1; j < m_numPartQ; j++) { | ||
| for (uint32_t j = 1; j < m_numPartQ; j++) { | ||
| uint32_t bits = moduliPartQ[j].GetLengthForBase(2); | ||
| if (bits > maxBits) | ||
| maxBits = bits; | ||
| } |
There was a problem hiding this comment.
uint32_t bits = 0, maxBits = 0;
for (auto&& m : moduliPartQ) {
if ((bits = m.GetLengthForBase(2)) > maxBits)
maxBits = bits;
}
pascoec
reviewed
Jun 11, 2024
pascoec
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.