Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/spec -- non_exhaustive enums, testStepId #6

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix/spec -- non_exhaustive enums, testStepId #6

merged 3 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. add non_exhaustive to public enums 

    - this is needed in case the spec adds new variants; otherwise we break
  consumers of these enums that may have matched exhaustively

Signed-off-by: mimir-d <[email protected]>
    @mimir-d
    mimir-d committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2e12ab1 View commit details
    Browse the repository at this point in the history

  2. current impl was missing testStepId; add it 

    - note that the tests are not catching the fact that this new field is
  missing from the expected output, because all the tests are doing an
  "included" test, rather than the correct equality; fixing this in a
  later commit

Signed-off-by: mimir-d <[email protected]>
    @mimir-d
    mimir-d committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f7a5696 View commit details
    Browse the repository at this point in the history

  3. remove a bunch of boilerplate 

    Signed-off-by: mimir-d <[email protected]>
    @mimir-d
    mimir-d committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e68165d View commit details
    Browse the repository at this point in the history