fix/spec -- non_exhaustive enums, testStepId #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimir-d
force-pushed
the
fix/separate_api_primitives
branch
from
82b8dd6
to
4c539af
Compare
mimir-d
changed the title
njordr
approved these changes
Oct 8, 2024
mimir-d
force-pushed
the
fix/separate_api_primitives
branch
from
4c539af
to
4987393
Compare
- this is needed in case the spec adds new variants; otherwise we break consumers of these enums that may have matched exhaustively Signed-off-by: mimir-d <[email protected]>
- note that the tests are not catching the fact that this new field is missing from the expected output, because all the tests are doing an "included" test, rather than the correct equality; fixing this in a later commit Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non_exhaustiveto public enumstestStepIdto step artifacts; required refactoring