Unify save requests #1472
Merged
Unify save requests #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user was saving (or saving and processing), we would sent two sequential POST requests, one for metadata and one for all the rest. This unifies the requests into a single one. Requires backend changes.
|
This pull request is deployed at test.editor.opencast.org/1472/2024-10-15_08-53-32/ . |
8 tasks
geichelberger
added a commit
to opencast/opencast
that referenced
this pull request
Dec 19, 2024
We have two endpoints for saving data from the editor frontend, one for metadata and one for all the rest. With the way the editor is set up, two seperate endpoints are wholly unnecessary, so this unifies them into one endpoint instead. Will break the frontend without respective changes: opencast/opencast-editor#1472 #### Why is this aimed at legacy? This constitutes a breaking change. This needs to be merged into whatever version the related frontend PR is merged into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485.
When the user was saving (or saving and processing), we would sent two sequential POST requests, one for metadata and one for all the rest. This unifies the requests into a single one.
Requires backend changes: opencast/opencast#6241