-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitle delete button #1511
Conversation
This pull request is deployed at test.editor.opencast.org/1511/2024-12-02_22-06-19/ . |
Thanks, Gregor, exactly what we were looking for. |
Adding this precludes updating the editor in 16.x anymore, which (as discussed in the dev meeting) is ok since we're not going to update the editor in 16 anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me and works.
If I create a subtitle, delete it and select "Save and Process", the new subtitle still shows up. This can probably be fixed by applying the changes made to Save.tsx
to the code in WorkflowConfiguration.tsx
(because there's code duplication going on ( #1472 will hopefully help with that at least a little bit)).
My editor found typescript complaints about the new delete property missing in:
- SubtitleEditor.tsx:51
- SubtitleSelect.tsx:238
I thought the subtitle slice handled the state, is there another state for starting the workflow? |
Yes, there are |
e354e72
to
c88c2e0
Compare
This pull request is deployed at test.editor.opencast.org/1511/2024-12-05_11-18-44/ . |
The PR #1413 should help with the duplicate save logic. After merging, I will rebase this. |
This pull request has conflicts ☹ |
This adds a subtitle delete button to the subtitle editor, which allows the deletion of newly created subtitles or already existing ones.
Change prepareSubtitles for WorklfowConfiguration to honor deleted subtitles.
c88c2e0
to
6ace5c0
Compare
This pull request is deployed at test.editor.opencast.org/1511/2024-12-09_14-06-38/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine now!
This adds a subtitle delete button to the subtitle editor, which allows the deletion of newly created subtitles or already existing ones.
Requires opencast/opencast#6361