Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle delete button #1511

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

geichelberger
Copy link
Contributor

@geichelberger geichelberger commented Dec 2, 2024

This adds a subtitle delete button to the subtitle editor, which allows the deletion of newly created subtitles or already existing ones.

Requires opencast/opencast#6361

image

@geichelberger geichelberger added type:enhancement New feature or request type:feature A new feature or feature request labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

This pull request is deployed at test.editor.opencast.org/1511/2024-12-02_22-06-19/ .
It might take a few minutes for it to become available.

@oas777
Copy link

oas777 commented Dec 3, 2024

Thanks, Gregor, exactly what we were looking for.

@gregorydlogan
Copy link
Member

Adding this precludes updating the editor in 16.x anymore, which (as discussed in the dev meeting) is ok since we're not going to update the editor in 16 anymore.

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me and works.

If I create a subtitle, delete it and select "Save and Process", the new subtitle still shows up. This can probably be fixed by applying the changes made to Save.tsx to the code in WorkflowConfiguration.tsx (because there's code duplication going on ( #1472 will hopefully help with that at least a little bit)).

My editor found typescript complaints about the new delete property missing in:

  • SubtitleEditor.tsx:51
  • SubtitleSelect.tsx:238

@geichelberger
Copy link
Contributor Author

I thought the subtitle slice handled the state, is there another state for starting the workflow?

@Arnei
Copy link
Member

Arnei commented Dec 4, 2024

Yes, there are workflowPostSlice.ts and workflowPostAndProcessSlice.ts.

Copy link

github-actions bot commented Dec 5, 2024

This pull request is deployed at test.editor.opencast.org/1511/2024-12-05_11-18-44/ .
It might take a few minutes for it to become available.

@geichelberger
Copy link
Contributor Author

The PR #1413 should help with the duplicate save logic. After merging, I will rebase this.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

This adds a subtitle delete button to the subtitle editor, which allows
the deletion of newly created subtitles or already existing ones.
Change prepareSubtitles for WorklfowConfiguration to honor deleted
subtitles.
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

This pull request is deployed at test.editor.opencast.org/1511/2024-12-09_14-06-38/ .
It might take a few minutes for it to become available.

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine now!

@Arnei Arnei merged commit 6c2e214 into opencast:main Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request type:feature A new feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants