Feature Flag evaluation event

[dyladan]

First draft of feature_flag.evaluation event from the feature flag semantic conventions working group. Based on proposal here: https://docs.google.com/document/d/1sBDD-uifx-Qy0NxtwRcrRAQ48sHQS9dTp6tpArQsoZg/edit

Summary of changes:

• Replace feature_flag.provider_name with feature_flag.provider.id feature_flag.system
• Rename feature_flag to feature_flag.evaluation
• Add attributes to feature_flag.evaluation
  • feature_flag.context.id
  • feature_flag.environment.id feature_flag.flag_set.id
  • feature_flag.value
  • feature_flag.version
• Remove feature flag span event
• Add feature_flag.error.code with values from https://openfeature.dev/specification/types/#resolution-details
• Add feature_flag.reason with values from https://openfeature.dev/specification/types/#resolution-details

[askpt]

I added a couple of comments; otherwise, it looks good.

[jsuereth]

FYI - you need to clean up the event group's id:

Diagnostic report:

Violation: Event id 'feature_flag.evaluation' is invalid. Event id must follow 'event.{name}' pattern and match 'event.feature_flag.evaluation'
  - Category         : yaml_schema_violation
  - Type             : semconv_attribute
  - SemConv group    : feature_flag.evaluation
  - SemConv attribute: feature_flag.evaluation
  - Provenance: /home/weaver/source/feature-flag/logs.yaml  

[dyladan]

@lmolkova I took the suggestion to use error.type but there isn't an equivalent error.message are we ok keeping the current feature_flag.evaluation.error.message or is there another name we should take for that one?

[dyladan]

@jsuereth like this? 43cdfd4

[lmolkova]

LGTM!

[joaopgrassi]

Please take a look and also, could you please update main/schema-next.yaml (list renamed attributes there)?

This is pending still.

[dyladan]

Please take a look and also, could you please update main/schema-next.yaml (list renamed attributes there)?

This is pending still.

Added feature_flag.provider_name -> feature_flag.system rename.

There are a couple changes I'm not sure how to make there (or if it's possible).

1. We removed the span semconv entirely in favor of events
2. We renamed the event from feature_flag to event.feature_flag.evaluation

[dyladan]

Please take a look and also, could you please update main/schema-next.yaml (list renamed attributes there)?

This is pending still.

Added feature_flag.provider_name -> feature_flag.system rename.

There are a couple changes I'm not sure how to make there (or if it's possible).

1. We removed the span semconv entirely in favor of events
2. We renamed the event from feature_flag to event.feature_flag.evaluation

According to https://opentelemetry.io/docs/specs/otel/schemas/file_format_v1.1.0 it looks like you can rename span_events but not top-level events? Additionally, it's still not clear at all to me how to handle the differences events/logs/span_events. Previously we had a file named log which had an event name and a file named span which had a span event. Now we only have an event. How do we map that in the schema? And if we want to keep span events, do we need multiple files or is it possible to have a single event definition that works for both?

[lmolkova]

There are a couple changes I'm not sure how to make there (or if it's possible).

We removed the span semconv entirely in favor of events
We renamed the event from feature_flag to event.feature_flag.evaluation

changelog entry is the best we can do today. Added some suggestions

[jsuereth]

@dyladan This Looks good to merge, assuming the conversations are resolved. The yamllint error - let me know if we need to update the settings. We may be hitting limitations in YAML event definitions and "max line length" rules...

[dyladan]

@dyladan This Looks good to merge, assuming the conversations are resolved. The yamllint error - let me know if we need to update the settings. We may be hitting limitations in YAML event definitions and "max line length" rules...

I wish the yaml lint would tell me which line is failing. I can't find where the error is actually caused. I think it's likely the table that I inlined for the error values? But that's only 197 characters