Fix make table-check command and regenerate tables
#1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
added
Skip Changelog
joaopgrassi
approved these changes
Sep 30, 2024
jsuereth
approved these changes
Sep 30, 2024
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
Oct 1, 2024
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making #1440 I was having trouble generating tables. It turns out that there was a syntax error in the
filesemconv, which is fixed here. I also noticed that thetable-checkwas passing when it shouldn't have been, which caused this error not to be caught in CI. Command in makefile fixed.