Fix MultiPolygon not iterable #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiyu Oh <[email protected]>
luca-della-vedova
approved these changes
May 31, 2024
|
Let's follow up with a PR to test this with the test map? |
|
The problem is that the issue is very rare and actually doesn't happen in any of our demo scenarios so it's unclear how to replicate it. It's probably some edge case with floor triangulation and polygon subtraction that is not immediately clear to me |
xiyuoh
added a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Xiyu Oh <[email protected]> (cherry picked from commit 34b38e1)
luca-della-vedova
pushed a commit
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Xiyu Oh <[email protected]>
luca-della-vedova
pushed a commit
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Xiyu Oh <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
added a commit
that referenced
this pull request
Nov 8, 2024
* Fix MultiPolygon not iterable (#496) Signed-off-by: Xiyu Oh <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]> * Handle geometry collections (#476) I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Yadunund <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]> --------- Signed-off-by: Xiyu Oh <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Xiyu <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]> Co-authored-by: Yadunund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #476,
shapelymigration requires a minor update to our code. Without this PR fix the following error will occur when building certain maps that involve MultiPolygon:TypeError: 'MultiPolygon' object is not iterable