Harmonic release and ECS refactor #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2024
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/ecs_plugins_sandbox
branch
from
e6f0d3b
to
d46fba0
Compare
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
mxgrey
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
The changes look good. I've tested this against 24.04 and rolling, and everything seems to be working.
Now I'll focus on reviewing open-rmf/rmf_simulation#114 and open-rmf/rmf_demos#206, and then we can merge all three simultaneously once CI is sorted out.
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/ecs_plugins_sandbox
branch
from
51aa78f
to
bcc2362
Compare
|
Uncrustify found a few issues with lines above 80 characters (not sure why it didn't before actually), addressed in bcc2362. Admin access is needed to remove the |
mxgrey
approved these changes
May 29, 2024
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
Needed for open-rmf/rmf_simulation#114.
Implementation description
This PR changes the world template to be up to date for Harmonic, as well as change our plugin simulations to use the ECS pattern (single door / lift system, each door / lift has a component registration system).
I'll try to see if we can do a gz / ign rename as well, but can't confirm that will happen yet
Bonus features:
ignitiontogazebo.