Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanups for nested model in ignition #195

Closed
wants to merge 2 commits into from
Closed

cleanups for nested model in ignition #195

wants to merge 2 commits into from

Conversation

Kevinskwk
Copy link
Collaborator

Cleanups for unused code in prepare of nested model support for ignition.
Should be ready to get merged when gazebosim/gz-sim#258 is merged for ign-gazebo4.

@luca-della-vedova luca-della-vedova marked this pull request as ready for review December 16, 2022 08:36
@luca-della-vedova
Copy link
Member

A similar but not quite the same fix has been bundled in #483.
Specifically, we can't naively remove the nesting as we planned to because Gazebo does not allow nested model joints to refer to their parents. What we have to do instead, is move the joints up in the hierarchy to be in the parent model and have them refer to the child model instead. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-della-vedova luca-della-vedova Awaiting requested review from luca-della-vedova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kevinskwk @luca-della-vedova