-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce v1beta1 API version #535
Conversation
Signed-off-by: odubajDT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 82.78% 82.81% +0.02%
==========================================
Files 22 24 +2
Lines 1423 1437 +14
==========================================
+ Hits 1178 1190 +12
- Misses 207 209 +2
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Thanks @odubajDT . I will give this a thorough review and test in the next few days. |
Nice work. I left few comments but this IMO is important as we always try to validate flag configurations against the schema. |
I'm ready to approve once this is adapted as in #352 (comment) |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@toddbaert @Kavindu-Dodan @beeme1mr PR adapted according to the discussion in #352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I noticed this (just a question).
Also I'm noticing a lint error in the CI which almost make it seems like a dependency might require a higher go version or something: https://github.com/open-feature/open-feature-operator/actions/runs/6730203336/job/18292441905?pr=535#step:6:493
Thank you! The error is present also in the main branch and is not related to this PR. I would say it should be resolved in a separate PR. I can have a look at it. |
The error comes with the usage of golangci-lint@latest - From version v1.54.2 onwards, there's a transitive dependency which require Go version 1.20.x+ . The quick fix for this PR is to fix makefile to v1.54.1 : https://github.com/open-feature/open-feature-operator/blob/main/Makefile#L88-L89 |
I already started working on a proper fix by moving the check to a separate workflow and also using a dedicated golangci-lint action for it #538 Hopefully it will be ready soon |
This PR
Related Issues
Fixes #529