Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy of OFO & flagd on file source naming #433

Closed
3 tasks done
Tracked by #528
Kavindu-Dodan opened this issue Mar 30, 2023 · 1 comment
Closed
3 tasks done
Tracked by #528

Discrepancy of OFO & flagd on file source naming #433

Kavindu-Dodan opened this issue Mar 30, 2023 · 1 comment
Assignees

Comments

@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Mar 30, 2023

Pre-requisites:

Background

flagd is capable of accepting file-based feature flag configurations.

From flagd documentation, file-based configurations are accepted with URI or Source with file prefix [1] .

flagd start --uri file:etc/featureflags.json

or sources yaml [2]

- uri: config/samples/example_flags.json
    provider: file

In OFO however, FlagSourceConfiguration require the provider to be filepath [3]

  - source: /etc/flags.json
    provider: filepath

This mixed usage has the potential for confusion.

Improvement

We should aim to unify this terminology, agreeing to a single name (similar to http, grpc and kubernets). Given that this is a breaking change, we could make this a part of beta version of the API with backward compatiblity.

[1] - https://flagd.dev/reference/sync-configuration/
[2] - https://flagd.dev/reference/sync-configuration/#source-configuration
[3] - https://github.com/open-feature/open-feature-operator/blob/main/docs/flag_source_configuration.md#source-fields

@odubajDT
Copy link
Contributor

odubajDT commented Nov 7, 2023

This issue was resolved by #535 in this place

@odubajDT odubajDT closed this as completed Nov 7, 2023
@odubajDT odubajDT self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants