IFFPdu improvements #5 and Unsafe equalsImpl for object list attributes #8

[mimmi-matalamaki-insta-fi]

We have modified IFFPdu that all five layers (1-5) can be added to IFFPdu.

Also fixed:

• TransmitterPdu has double extraction of RadioID #11
• Missing padding field in marshalling and unmarshalling ElectronicEmitter #12
  -HashCode added to JavaGenerator and Domain.java class. Missing hashcode caused problems if for example EntityIDs was added to list and then used contains-method of list.

We have fixed issue:

• Unsafe equalsImpl for object list attributes #8

[brutzman]

Thank you very much for this careful modification.

@terry-norbraten and I are looking at it closely, since it will be our first effort to handle a pull request in this library.

We expect to clone your branch of opendis7-source-generator changes to test before accepting. We will also run your new test class in opendis7-java: test/IFFPduTest.java. If everything works, we will merge those changes (and not the other opendis7-java source changes, which should get autogenerated). Otherwise we will provide further questions/suggestions.

Am expecting we might rename Mode5StatusRecord class as IFFMode5StatusRecord but that step can wait until everything else works.

We will also be looking at available string constants for PDU names, in order to avoid potential typos.

Your professional and patience is appreciated, we will ask questions if we have them.

[terry-norbraten]

Special thanks to mimmi-matalamaki-insta-fi and to arttu-salminen-insta-fi for the IFFPdu layers expansion and the other mentioned fixes for #8, #11 and #12.

[mimmi-matalamaki-insta-fi]

We are happy that you merged our pull-request to part of your master branch code and that we have managed to bring value of this project.