Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iff pdu improvements and Unsafe equalsImpl for object list attributes #23

Conversation

mimmi-matalamaki-insta-fi
Copy link

@mimmi-matalamaki-insta-fi mimmi-matalamaki-insta-fi commented Nov 29, 2023

We have generated code based on open-dis/opendis7-source-generator#15 -pullrequest open in opendis7-source-generator project. We have added IFFPduTest.java and Mode5StatusRecord.java classes.

@brutzman
Copy link
Contributor

We are first testing the opendis7-source-generator pull request first, in order to see if that handles these dependencies when updating via build all.

@brutzman
Copy link
Contributor

brutzman commented Dec 21, 2023

We are committing and pushing the following files manually since all of the other changes were autogenerated files that are now superseded. Test results are satisfactory as shown by build.test.log.txt output.

  • edu.nps.moves.dis7.test.IFFPduTest.java
  • edu.nps.moves.dis7.utilities.Mode5StatusRecord

Wondering if the second class is better positioned next to IFFPduLayer3InterrogatorFormatData, IFFPduLayer3TransponderFormatData classes, and also renamed as

  • edu.nps.moves.dis7.test.IFFMode5StatusRecord

Feedback welcome. We plan to perform this refactoring if there are no objections.

@mimmi-matalamaki-insta-fi
Copy link
Author

Hello, for us it is ofcourse okay that you refactor class names and the code the way you like it better.

@brutzman
Copy link
Contributor

brutzman commented Dec 29, 2023

All opendis7-java source-code merges handled manually, all conflicts resolved.

@brutzman brutzman closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants