-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasmine physical cyrcadian rhythm #205
Conversation
…m/onnela-lab/forest into jasmine-physical_cyrcadian_rhythm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, gps_summaries()
is ~700 lines of code right now. Is there a way to simplify or refactor?
…m/onnela-lab/forest into jasmine-physical_cyrcadian_rhythm
…et_time_range, compute_window_and_windows_count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Also, would it make sense to add some unit tests for the new functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hyperparameters
class to reduce parameters used ingps_stats_main