Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine physical cyrcadian rhythm #205

Merged
merged 31 commits into from
Oct 30, 2023
Merged

Conversation

GeorgeEfstathiadis
Copy link
Collaborator

  • add physical cyrcadian rhythm and stratified physical cyrcadian rhythm columns
  • move rarely-used parameters to Hyperparameters class to reduce parameters used in gps_stats_main

@GeorgeEfstathiadis GeorgeEfstathiadis added the enhancement New feature or request label Oct 16, 2023
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, gps_summaries() is ~700 lines of code right now. Is there a way to simplify or refactor?

docs/source/jasmine.md Outdated Show resolved Hide resolved
docs/source/jasmine.md Outdated Show resolved Hide resolved
docs/source/jasmine.md Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Show resolved Hide resolved
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also, would it make sense to add some unit tests for the new functions?

forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

forest/jasmine/traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
forest/jasmine/tests/test_traj2stats.py Outdated Show resolved Hide resolved
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hackdna hackdna merged commit 8768ee3 into develop Oct 30, 2023
3 checks passed
@hackdna hackdna deleted the jasmine-physical_cyrcadian_rhythm branch October 30, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants