Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NATIVECPU] Add UR_DEVICE_INFO_MAX_WORK_GROUP_SIZE for device info #2162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/adapters/native_cpu/device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
case UR_DEVICE_INFO_MAX_WORK_GROUP_SIZE:
// TODO: provide a mechanism to estimate/configure this.
return ReturnValue(size_t{2048});
case UR_DEVICE_INFO_MAX_NUM_SUB_GROUPS:
// Set the max sub groups to be the same as the max work group size.
return ReturnValue(uint32_t{2048});
case UR_DEVICE_INFO_MEM_BASE_ADDR_ALIGN:
// Imported from level_zero
return ReturnValue(uint32_t{8});
Expand Down Expand Up @@ -357,7 +360,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
case UR_DEVICE_INFO_GPU_HW_THREADS_PER_EU:
case UR_DEVICE_INFO_UUID:
case UR_DEVICE_INFO_DEVICE_ID:
case UR_DEVICE_INFO_MAX_NUM_SUB_GROUPS:
case UR_DEVICE_INFO_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS:
case UR_DEVICE_INFO_IL_VERSION:
case UR_DEVICE_INFO_MAX_WORK_GROUPS_3D:
Expand Down
1 change: 0 additions & 1 deletion test/conformance/device/device_adapter_native_cpu.match
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GLOBAL_MEM_FREE
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_QUEUE_ON_DEVICE_PROPERTIES
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_QUEUE_ON_HOST_PROPERTIES
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_IL_VERSION
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_NUM_SUB_GROUPS
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_UUID
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_PCI_ADDRESS
Expand Down
Loading