Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NATIVECPU] Add UR_DEVICE_INFO_MAX_WORK_GROUP_SIZE for device info #2162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coldav
Copy link
Contributor

@coldav coldav commented Oct 2, 2024

Native CPU was not setting UR_DEVICE_INFO_MAX_WORK_GROUP_SIZE and therefore failing some SYCL CTS tests. This sets it to the same as the max workgroup size.

@coldav coldav requested a review from a team as a code owner October 2, 2024 09:34
@coldav coldav force-pushed the colin/device_info_max_sub_groups branch from eb9a25f to d6f035e Compare October 2, 2024 09:37
@coldav coldav force-pushed the colin/device_info_max_sub_groups branch from d6f035e to df1d56e Compare October 2, 2024 15:50
@coldav coldav requested a review from a team as a code owner October 2, 2024 15:50
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTS changes LGTM

@coldav
Copy link
Contributor Author

coldav commented Oct 3, 2024

intel/llvm#15589

@github-actions github-actions bot added conformance Conformance test suite issues. native-cpu Native CPU adapter specific issues labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants