[DeviceSanitizer] Only try to get backtrace symbols when needed #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
yingcong-wu
reviewed
Sep 25, 2024
yingcong-wu
approved these changes
Sep 25, 2024
AllanZyne
approved these changes
Sep 26, 2024
|
Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? Thanks. |
pbalcer
approved these changes
Oct 10, 2024
| Stack.stack.emplace_back(addr_info); | ||
| } | ||
| free(Symbols); | ||
| Stack.stack = |
There was a problem hiding this comment.
nit, we should be able to skip the stack buffer by writing to the vector directly:
StackTrace Stack;
Stack.stack.reserve(MAX_BACKTRACE_FRAMES);
int FrameCount = backtrace(Stack.stack.data(), MAX_BACKTRACE_FRAMES);
There was a problem hiding this comment.
I didn't want to delay merging because of this. If you want to change it, include it in another PR.
There was a problem hiding this comment.
Thanks. I'll do this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.