[DeviceASAN] Move validation layer before sanitizer layer

[zhaomaosu]

Avoid internal UR API calls from sanitizer layer being intercepted by validation layer for better performance.
For miniqmc, the runtime can be reduced by -21.46% with this change.

[yingcong-wu]

Do we have some performance data here?

[zhaomaosu]

Do we have some performance data here?

Updated the git messages

[yingcong-wu]

Do we have some performance data here?

Updated the git messages

Great, a good improvement.

[pbalcer]

I'm not opposed, but I'm not sure I understand the concern about performance. The validation layer is disabled by default. Users can just chose to not enable it if they observe reduced performance.

[zhaomaosu]

I'm not opposed, but I'm not sure I understand the concern about performance. The validation layer is disabled by default. Users can just chose to not enable it if they observe reduced performance.

Eh....Actually, it's because intel openmp offload runtime will enable validation layer by default in their ur plugin. BTW, the overhead comes mainly from 'backtrace_symbols'. Maybe we can also do same changes in validation layer as PR #2128

[pbalcer]

BTW, the overhead comes mainly from 'backtrace_symbols'. Maybe we can also do same changes in validation layer as PR #2128

At some point we should move the backtrace implementation into common and have only one implementation.

[pbalcer]

Eh....Actually, it's because intel openmp offload runtime will enable validation layer by default in their ur plugin

They should stop doing that. It hurts performance overall, not just when sanitizer is enabled. If they want to retain some lightweight validation, they should enable only parameter validation (which is reasonable to leave always enabled).

[zhaomaosu]

They should stop doing that. It hurts performance overall, not just when sanitizer is enabled. If they want to retain some lightweight validation, they should enable only parameter validation (which is reasonable to leave always enabled).

Thanks. I'll suggest them not to enable full validation layer by default.