Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues 26, 198 #46

Closed
wants to merge 1 commit into from
Closed

Fix Issues 26, 198 #46

wants to merge 1 commit into from

Commits on Sep 5, 2023

  1. Fix Issues 26, 198

    Summary: An attacker can manipulate the interest_, loanToCollateral_, duration_ parameters, bypassing Clearinghouse.rollLoan(); Lender is able to steal borrowers collateral by calling rollLoan with unfavourable terms on behalf of the borrower.
    Issue Links: sherlock-audit/2023-08-cooler-judging#198 ; sherlock-audit/2023-08-cooler-judging#26
    Fix Description: Only allow lender to enable rollover at the same terms as origination, instead of with newly proposed terms.
    ohmzeus authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    89c3610 View commit details
    Browse the repository at this point in the history