Fix Issues 26, 198 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: An attacker can manipulate the interest_, loanToCollateral_, duration_ parameters, bypassing Clearinghouse.rollLoan(); Lender is able to steal borrowers collateral by calling rollLoan with unfavourable terms on behalf of the borrower. Issue Links: sherlock-audit/2023-08-cooler-judging#198 ; sherlock-audit/2023-08-cooler-judging#26 Fix Description: Only allow lender to enable rollover at the same terms as origination, instead of with newly proposed terms.
|
Note for collaborators: provideNewTermsForRoll() parameters were not changed although all are now unused. This was done to prevent all the tests from breaking (though that seems to have been unsuccessful). We need to change interfaces and interactions where affected in src/ and tests. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: An attacker can manipulate the interest_, loanToCollateral_, duration_ parameters, bypassing Clearinghouse.rollLoan(); Lender is able to steal borrowers collateral by calling rollLoan with unfavourable terms on behalf of the borrower.
Issue Links: sherlock-audit/2023-08-cooler-judging#198 ; sherlock-audit/2023-08-cooler-judging#26
Fix Description: Only allow lender to enable rollover at the same terms as origination, instead of with newly proposed terms.