-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pandas issues #34
Conversation
It seems, pandas requires minimum versions of numpy, but only checks for them instead of doing proper dependency handling. As a workaround, we can define a minimum version for numpy, that will work with recent releases of pandas.
Setting pandas to < 1.2 might workaround the issue but does not solve it. 1.2 has improved error detection, so our code is probably erroneous: |
The decrease in Coverage is actually caused by the dynamic H0 function. As the CI pipeline was broken, however, the decreased coverage was not recognised. In my opinion, the testing should be addressed in another PR. |
A proper solution might be to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that the results of the examples are unchanged. Considering that the last release is actually broken, @uvchik agreed that my self-review this is good enough.
This PR introduces the following changes: