Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are no unit tests #35

Open
p-snft opened this issue Jan 24, 2021 · 0 comments
Open

There are no unit tests #35

p-snft opened this issue Jan 24, 2021 · 0 comments
Milestone
v0.2.0

Comments

@p-snft
Copy link
Member

p-snft commented Jan 24, 2021 •
edited
Loading

What is called "unit test", is actually an integration test calculating the sum. This does not find serious issues, e.g. if timestamps are shuffled in the profiles. (This happened in #34 but was is detected by the tests)
@p-snft p-snft mentioned this issue Jan 26, 2021
Merged
p-snft added a commit that referenced this issue Jan 27, 2021
@p-snft
Merge pull request #34 from oemof/fix/dependency_compat
1b7a58d 
* Rework generation of time series to allow usage of Pandas >= 1.2
* Require more recent version of dependencies (pandas>=1.0, numpy >= 1.17)
* Split electric and thermal profile generation into two files (helped with debugging)
* Test sums over individual profiles instead of sum over all profiles (still no unit test, but an improvement, see #35)
@uvchik uvchik added this to the Release v0.2 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@uvchik @p-snft