-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zbus 5.0 #209
base: main
Are you sure you want to change the base?
Conversation
TTWNO
commented
Nov 5, 2024
- Update zbus dep too
- Upgrade atspi-common to zbus 5.x; some formatting and clippy fixes also included
- Update atspi-proxies to zbus 5.x
- Add pub modifier for public Bus,Registry,Status proxies
- Update atspi-connections to zbus 5.x
- Use new static signature assertions
- Fix tests so they run (many fail)
- Formatting
- Use the non-parenthesis string for comparison
- Fix additional tests via using string instead of static signature variation; necessary due to dynamic/static difference
- formatting
- use git instead of path
- Use pub modifier in traits
- Test signature instead of string representation
- use static instead of const for structure defs
- Use const Signature for matching
…iation; necessary due to dynamic/static difference
Thank you very much for the hard work @TTWNO. I will however, once again, say that it is too soon to update to zbus 5.0 for the simple fact that it requires Rust 1.80. At the time of writing, most crates in the GUI space are not there yet. |
Would you prefer that this PR not be merged until |
I was not even talking about AccessKit here. Someone else did the migration to zbus 4 and I accepted it because pressure was starting to build up on us. Finalizing the update to latest atspi is on my TODO list now. Given that the users of this crate are Odilia and most Rust UI toolkits through AccessKit, I think you should at least wait for the majority of them to bump their MSRV to 1.80. |
This fixes the test in common/action, where `Action` is validated against its XML description.