Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade MSRV to 1.80 #1107

Closed
zeenix opened this issue Oct 29, 2024 · 2 comments · Fixed by #1108
Closed

Downgrade MSRV to 1.80 #1107

zeenix opened this issue Oct 29, 2024 · 2 comments · Fixed by #1108

Comments

@zeenix
Copy link
Contributor

zeenix commented Oct 29, 2024

Seems 1.81 is too new for some distros but 1.80 is fine. So let's downgrade to 1.80.

ids1024 added a commit to ids1024/zbus that referenced this issue Oct 29, 2024
Require a slightly older and slightly more universally available Rust
release. Rust 1.81 doesn't seem to have many features that Zbus would
likely need.

Fixes dbus2#1107.
zeenix pushed a commit to ids1024/zbus that referenced this issue Oct 29, 2024
Require a slightly older and slightly more universally available Rust
release. Rust 1.81 doesn't seem to have many features that zbus would
likely need.

Fixes dbus2#1107.
@ids1024
Copy link
Contributor

ids1024 commented Nov 6, 2024

MSRV also seems to be a concern for the atspi crate (used by accesskit): odilia-app/atspi#209 (comment).

(It would definitely help if there was some ecosystem agreement about what MSRV is appropriate to target.)

@luukvanderduim
Copy link
Contributor

Upstream binaries presumably do not care that much, however, with respect to MSRV, the library ecosystem suffers from what Australians call "tall poppy syndrome". It is generally frowned upon to be the first to adopt a later version than some unspoken agreed upon version. As - over time - incrementing MSRV is inevitable anyway, I cheer for those courageous libraries that blink first and increment MSRV because it is unfortunate we hold each other back like this.

We would like atspi to be efficient and have a lighter dependency tree whenever we can, thus we welcomed zbus v4 and now v5. The obvious downside is that some users, notably AccessKit, may not be able to use the latest. It is a difficult problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants