Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes modules and macros #163

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Small fixes modules and macros #163

merged 3 commits into from
Mar 19, 2024

Commits on Mar 19, 2024

  1. unnecessary pub visibility on test-time modules.

    @luukvanderduim
    luukvanderduim committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    5363491 View commit details
    Browse the repository at this point in the history

  2. remove macro_export attribute. 

    - The attribute does not work on the module a a whole.
- We intend to use these macros in atspi-common only.

We use:

```rust
#[macro_use]
pub(crate) mod macros;
```
in libs, which satisfies our our needs.
    @luukvanderduim
    luukvanderduim committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bd56fd0 View commit details
    Browse the repository at this point in the history

  3. Explain why we decorate some macros. 

    We decorate the macro with a `#[cfg(test)]` attribute.
This prevents Clippy from complaining about the macro not being used. It is being used, but only in test mode.
    @luukvanderduim
    luukvanderduim committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e0cdd5a View commit details
    Browse the repository at this point in the history