Small fixes modules and macros #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 89.38% 89.41% +0.03%
==========================================
Files 39 39
Lines 3268 3268
==========================================
+ Hits 2921 2922 +1
+ Misses 347 346 -1 ☔ View full report in Codecov by Sentry. |
luukvanderduim
force-pushed
the
small_fixes_modules_and_macros
branch
from
c34c4c0
to
2cd4719
Compare
- The attribute does not work on the module a a whole. - We intend to use these macros in atspi-common only. We use: ```rust #[macro_use] pub(crate) mod macros; ``` in libs, which satisfies our our needs.
We decorate the macro with a `#[cfg(test)]` attribute. This prevents Clippy from complaining about the macro not being used. It is being used, but only in test mode.
luukvanderduim
force-pushed
the
small_fixes_modules_and_macros
branch
from
2cd4719
to
e0cdd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
pubvisibility on test-time modules.Remove
#[macro_export]from top of macros module.#[macro_export]does not work on a whole module and it is intended to make a macro available outside the crate. We do not want these macros to be part of our public API.The way we make the modules available across the crate modules is by:
We have some macros of which Clippy thinks are unused. They are used, but only in the test profile.
This adds a comment explaining why we make the macro available under test only.
(Alternatively we could opt-out of the lint. )