-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1413: Update and split dash_duo tests #1417
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e6609c4
issue-1413: update and split dash_duo tests
kdetry 78f5429
issue-1413: refactor and comment lines
kdetry 6471ebe
issue-1413: test fix
kdetry c89b396
Separate app setup into a function.
calina-c cd08012
Start tests for favourite addresses autoload.
calina-c c4ba616
Fixes issue with non-clickable elements.
calina-c b83282e
Adds more tests to selectors.
calina-c 1e85fa9
Linter fixes, attempt to fix screen size issue.
calina-c ffa99f2
changed tables height
KatunaNorbert 4d87688
make tables hight even smaller
KatunaNorbert b05334c
pylint fixes
KatunaNorbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
184 changes: 92 additions & 92 deletions
184
pdr_backend/analytics/predictoor_dashboard/test/test_callbacks.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,116 +1,116 @@ | ||
| import time | ||
| import pytest | ||
|
|
||
| from dash import Dash | ||
| import dash_bootstrap_components as dbc | ||
| from selenium.webdriver.common.keys import Keys | ||
|
|
||
| from pdr_backend.analytics.predictoor_dashboard.dash_components.callbacks import ( | ||
| get_callbacks, | ||
| ) | ||
| from pdr_backend.analytics.predictoor_dashboard.dash_components.view_elements import ( | ||
| get_layout, | ||
| ) | ||
| from pdr_backend.analytics.predictoor_dashboard.dash_components.util import ( | ||
| get_feeds_data_from_db, | ||
| get_predictoors_data_from_payouts, | ||
| get_user_payouts_stats_from_db, | ||
| ) | ||
| from pdr_backend.analytics.predictoor_dashboard.test.resources import ( | ||
| _prepare_test_db, | ||
| _clear_test_db, | ||
| _input_action, | ||
| start_server_and_wait, | ||
| ) | ||
| from pdr_backend.lake.payout import Payout | ||
| from pdr_backend.lake.prediction import Prediction | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def _test_analytics_app(): | ||
| app = Dash(__name__) | ||
| get_callbacks(app) | ||
| return app | ||
| def test_get_input_data_from_db(setup_app, dash_duo): | ||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
|
|
||
|
|
||
| def test_startup( | ||
| tmpdir, | ||
| _sample_daily_predictions, | ||
| _sample_payouts_related_with_predictions, | ||
| dash_duo, | ||
| ): | ||
| _clear_test_db(str(tmpdir)) | ||
| def test_feeds_search_input(setup_app, dash_duo): | ||
| """ | ||
| Test the search input in the "Feeds" table. | ||
| The search input is used to filter the feeds by their name. | ||
| """ | ||
|
|
||
| _prepare_test_db( | ||
| tmpdir, | ||
| _sample_payouts_related_with_predictions, | ||
| table_name=Payout.get_lake_table_name(), | ||
| ) | ||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
| _input_action(dash_duo, "#search-input-Feeds", "#feeds_table", "OCEAN", 1) | ||
| _input_action(dash_duo, "#search-input-Feeds", "#feeds_table", "BTC", 2) | ||
| _input_action(dash_duo, "#search-input-Feeds", "#feeds_table", "ADA", 2) | ||
|
|
||
| ppss, _ = _prepare_test_db( | ||
| tmpdir, | ||
| _sample_daily_predictions, | ||
| table_name=Prediction.get_lake_table_name(), | ||
| ) | ||
|
|
||
| app = Dash(__name__, external_stylesheets=[dbc.themes.BOOTSTRAP]) | ||
| app.config["suppress_callback_exceptions"] = True | ||
| app.layout = get_layout() | ||
| app.lake_dir = ppss.lake_ss.lake_dir | ||
| app.feeds_data = get_feeds_data_from_db(ppss.lake_ss.lake_dir) | ||
| app.predictoors_data = get_predictoors_data_from_payouts( | ||
| get_user_payouts_stats_from_db(ppss.lake_ss.lake_dir) | ||
| def test_predictoors_search_input(setup_app, dash_duo): | ||
| """ | ||
| Test the search input in the "Predictoors" table. | ||
| The search input is used to filter the predictoors by their name. | ||
| """ | ||
|
|
||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
|
|
||
| _input_action( | ||
| dash_duo, "#search-input-Predictoors", "#predictoors_table", "0xaaa", 1 | ||
| ) | ||
| _input_action( | ||
| dash_duo, "#search-input-Predictoors", "#predictoors_table", "0xd2", 2 | ||
| ) | ||
| app.favourite_addresses = ppss.predictoor_ss.my_addresses | ||
| get_callbacks(app) | ||
|
|
||
| dash_duo.start_server(app) | ||
| dash_duo.wait_for_element("#feeds_table") | ||
| dash_duo.wait_for_element("#predictoors_table") | ||
|
|
||
| dash_duo.wait_for_element("#feeds_table tbody tr") | ||
| dash_duo.wait_for_element("#predictoors_table tbody tr") | ||
| def test_checkbox_selection(setup_app, dash_duo): | ||
| """ | ||
| Test the selection of checkboxes in the "Feeds" and "Predictoors" tables. | ||
| """ | ||
|
|
||
| # ----TEST SEARCH INPUT WITH "OCEAN" VALUE----# | ||
| dash_duo.find_element("#search-input-Feeds").send_keys("OCEAN" + Keys.ENTER) | ||
| # wait 5 seconds | ||
| time.sleep(2) | ||
| assert len(dash_duo.find_elements("#feeds_table tbody tr")) == 1 | ||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
|
|
||
| # click on the checkbox in the second row of the "Feeds" table | ||
| dash_duo.find_element("#feeds_table tbody tr:nth-child(2) input").click() | ||
|
|
||
| # click on the checkbox in the first row of the "Predictoors" table | ||
| dash_duo.find_element("#predictoors_table tbody tr input").click() | ||
|
|
||
| # ----TEST SEARCH INPUT WITH "BTC" VALUE----# | ||
| # reset the search input | ||
| dash_duo.find_element("#search-input-Feeds").clear() | ||
| # enter "BTC" phrase to the "search-input-Feeds" input | ||
| dash_duo.find_element("#search-input-Feeds").send_keys("BTC" + Keys.ENTER) | ||
|
|
||
| def test_timeframe_metrics(setup_app, dash_duo): | ||
| """ | ||
| Test the metrics that are displayed when a predictoor is selected. | ||
| It takes the predictoor row from the table and compares with the top metrics. | ||
|
|
||
| The metrics are: Profit, Accuract, Stake | ||
| """ | ||
|
|
||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
|
|
||
| dash_duo.find_element("#predictoors_table tbody tr:nth-child(3) input").click() | ||
| time.sleep(2) | ||
| # check if the "Feeds" table has only two rows | ||
| assert len(dash_duo.find_elements("#feeds_table tbody tr")) == 2 | ||
|
|
||
| # ----TEST SEARCH INPUT WITH "ADA" VALUE----# | ||
| # reset the search input | ||
| dash_duo.find_element("#search-input-Feeds").clear() | ||
| # enter "BTC" phrase to the "search-input-Feeds" input | ||
| dash_duo.find_element("#search-input-Feeds").send_keys("ADA" + Keys.ENTER) | ||
|
|
||
| dash_duo.find_element("#feeds_table tbody tr:nth-child(2) input").click() | ||
| time.sleep(2) | ||
|
|
||
| # check if the "Feeds" table has only two rows | ||
| assert len(dash_duo.find_elements("#feeds_table tbody tr")) == 2 | ||
| table_profit = dash_duo.find_element( | ||
| "#predictoors_table tbody tr:nth-child(3) td:nth-child(3)" | ||
| ).text | ||
| metric_profit = dash_duo.find_element("#profit_metric").text | ||
| assert table_profit + " OCEAN" == metric_profit | ||
|
|
||
| # ----TEST PREDICTOOR INPUT WITH "0xaaa" VALUE----# | ||
| dash_duo.find_element("#search-input-Predictoors").send_keys("0xaaa" + Keys.ENTER) | ||
| time.sleep(2) | ||
| assert len(dash_duo.find_elements("#predictoors_table tbody tr")) == 1 | ||
| table_accuracy = dash_duo.find_element( | ||
| "#predictoors_table tbody tr:nth-child(3) td:nth-child(4)" | ||
| ).text | ||
| metric_accuracy = dash_duo.find_element("#accuracy_metric").text | ||
| assert table_accuracy + ".0%" == metric_accuracy | ||
|
|
||
| table_stake = dash_duo.find_element( | ||
| "#predictoors_table tbody tr:nth-child(3) td:nth-child(5)" | ||
| ).text | ||
| metric_stake = dash_duo.find_element("#stake_metric").text | ||
| assert table_stake + " OCEAN" == metric_stake | ||
|
|
||
| # ----TEST PREDICTOOR INPUT WITH "0xd2" VALUE----# | ||
| # clear input | ||
| dash_duo.find_element("#search-input-Predictoors").clear() | ||
| # enter "0xd2" phrase to the "search-input-Predictoors" input | ||
| dash_duo.find_element("#search-input-Predictoors").send_keys("0xd2" + Keys.ENTER) | ||
|
|
||
| def test_predictoors_feed_only_switch(setup_app, dash_duo): | ||
| """ | ||
| Test the switch that toggles between showing only the feeds that are | ||
| associated with the selected predictoor and all feeds. | ||
| """ | ||
|
|
||
| app = setup_app | ||
| start_server_and_wait(dash_duo, app) | ||
|
|
||
| dash_duo.find_element("#predictoors_table tbody tr:nth-child(3) input").click() | ||
| time.sleep(2) | ||
|
|
||
| # check if the "Predictoors" table has only one row | ||
| assert len(dash_duo.find_elements("#predictoors_table tbody tr")) == 2 | ||
| feeds_table_len = len(dash_duo.find_elements("#feeds_table tbody tr")) | ||
| assert feeds_table_len == 2 | ||
|
|
||
| # click on the checkbox in the second row of the "Feeds" table | ||
| dash_duo.find_element("#feeds_table tbody tr:nth-child(2) input").click() | ||
| # Scroll the toggle switch into view and click using JavaScript | ||
| toggle_switch = dash_duo.find_element("#toggle-switch-predictoor-feeds") | ||
| dash_duo.driver.execute_script("arguments[0].scrollIntoView(true);", toggle_switch) | ||
| dash_duo.driver.execute_script("arguments[0].click();", toggle_switch) | ||
| time.sleep(2) | ||
|
|
||
| # click on the checkbox in the first row of the "Predictoors" table | ||
| dash_duo.find_element("#predictoors_table tbody tr input").click() | ||
| feeds_table_len = len(dash_duo.find_elements("#feeds_table tbody tr")) | ||
| assert feeds_table_len == 6 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid possible inconsistencies with this part, let's create a function that takes app and ppss as parameters, called e.g.
setup_predictoor_dashboardand add predictoors_data, feeds_data, lake_dir, favourite_addresses. Call this function here and where this code is duplicated. I wanted to do this myself at the last round of fixes but I missed itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other dashboards have at most one line of setup, so that's why we just copy that setup in the tests, but here I think it's safer to do a function