-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1413: Update and split dash_duo tests #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some more cases to cover.
- starting up with favourite addresses that have payouts -> should check all feeds by default and load payouts at startup.
- toggling the switches for "my predictoors" and "only feeds with payouts"
- date toggles should filter the data
I understand we are trying to split the tests, but we also need to figure out how to combine some of these to avoid long time waits. I.e. maybe a single test for toggles/switches that tries both inputs, as opposed to starting with a "virgin" setup every time.
|
||
app.layout = get_layout() | ||
app.lake_dir = ppss.lake_ss.lake_dir | ||
app.feeds_data = get_feeds_data_from_db(ppss.lake_ss.lake_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid possible inconsistencies with this part, let's create a function that takes app and ppss as parameters, called e.g. setup_predictoor_dashboard
and add predictoors_data, feeds_data, lake_dir, favourite_addresses. Call this function here and where this code is duplicated. I wanted to do this myself at the last round of fixes but I missed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other dashboards have at most one line of setup, so that's why we just copy that setup in the tests, but here I think it's safer to do a function
* Fix #1376: Change callbacks to not store payout data (#1378) * Fix #1375: Add Buttons and Sorting (#1379) * Fix #1373: Separate some concerns in pdr-dashboard. (#1390) * Fix #1374: Display metrics over multiple feeds and predictoors (#1377) * Fix #1400: Fix selections in feed and predictoor list (#1401) * Fix #1385: Add switch to display selected predictoors feeds only (#1395) * Fix #1402: Allow address config for predictoor dashboard. (#1403) * Fix #1404: Allow date period selection (#1405) * Fix #1384: Improve predictoors table by adding accuracy, stake and profit (#1398) * Fix #1409: Add predictoor and feed startup data instead of loading on a dash component (#1411) * Fix #1412: Update dashboard readme with new instructions (#1414) * Fix #1413: Update and split dash_duo tests (#1417)
Fixes #1413