fix: type of Pp.paragraphf and add changelog #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mbarbin
reviewed
Oct 31, 2023
There was a problem hiding this comment.
@Alizter I think this change is enough to give you the compile time error on the ml, so you don't need the annotation in the ml once you have this change.
|
needs a rebase |
We define the format string internally so that it can be enforced somewhat. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/fix__type_of_pp_paragraphf_and_add_changelog
branch
from
ecde6a1
to
7f5a115
Compare
|
@rgrinberg done. |
Alizter
deleted the
ps/branch/fix__type_of_pp_paragraphf_and_add_changelog
branch
Merged
mbarbin
added a commit
to mbarbin/opam-repository-1
that referenced
this pull request
Sep 16, 2024
CHANGES: - Prepare release (ocaml-dune/pp#21, @mbarbin) - Upgrade to `ocamlformat.0.26.2`. - Fmt the code - Add CI badge to README - Upgrade GitHub workflow actions dependencies (checkout@v4, setup-ocaml@v3) - Add more validation steps in CI - Add `ocamlformat` as dev-setup dependency - Add `Pp.verbatimf`. (ocaml-dune/pp#18, @mbarbin) - Add `Pp.paragraph` and `Pp.paragraphf` (ocaml-dune/pp#19, @Alizter) - Remove `of_fmt` constructor. (ocaml-dune/pp#17, @Alizter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define the format string internally so that it can be enforced somewhat.