Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] pp (2.0.0) #26570

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[new release] pp (2.0.0) #26570

merged 2 commits into from
Sep 17, 2024

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Sep 16, 2024

Pretty-printing library

CHANGES:

CHANGES:

- Prepare release (ocaml-dune/pp#21, @mbarbin)
  - Upgrade to `ocamlformat.0.26.2`.
  - Fmt the code
  - Add CI badge to README
  - Upgrade GitHub workflow actions dependencies (checkout@v4, setup-ocaml@v3)
  - Add more validation steps in CI
  - Add `ocamlformat` as dev-setup dependency

- Add `Pp.verbatimf`. (ocaml-dune/pp#18, @mbarbin)

- Add `Pp.paragraph` and `Pp.paragraphf` (ocaml-dune/pp#19, @Alizter)

- Remove `of_fmt` constructor. (ocaml-dune/pp#17, @Alizter)
@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 16, 2024

I just had a first look at the CI results. This release contains ocaml-dune/pp#17 which has a breaking change to the public APi of pp. In particular Pp.to_ast no longer returns a result type. This is causing a good number of the build issues I see in the CI.

I think the normal way of fixing this is to introduce a new version constraints to these packages (& < 2.0.0 ). Is that right?

@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 16, 2024

cc @rgrinberg

@mseri
Copy link
Member

mseri commented Sep 16, 2024

Thanks.

@mbarbin would it be possible to move 745b16a to a separate PR? This way I can directly merge and we can re-run the tests here. Otherwise the revdeps will hit heavily the CI

@mseri
Copy link
Member

mseri commented Sep 17, 2024

pp revdeps are all green, the builds are green. I am merging to avoid testing all revdeps of dune multiple times

@mseri mseri merged commit 5c34d67 into ocaml:master Sep 17, 2024
2 of 3 checks passed
@mbarbin mbarbin deleted the release-pp-2.0.0 branch September 17, 2024 07:39
@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants