-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAK matching to uPheno 2 #43
base: master
Are you sure you want to change the base?
Conversation
matentzn
commented
Nov 7, 2022
•
edited by hrshdhgd
Loading
edited by hrshdhgd
- Add OAK pipeline (including matching rules (same layout as mondo-ingest)
- matching rules must contain a rule to strip out all content between brackets
- For now, just download the dependency from https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_all_with_relations.owl instead of trying to run the pipeline yourself.
- YOu can create a subset of uPheno that is relevant like this:
@matentzn , I may need a |
For which part exactly? |
filtering prefixes. Do we need to do that? Similar to this. |
Yes, better.. There is sooo much noise we don't care about in uPheno! |
Where do I grab that from? Or does that need to be curated? |
No great file atm, but you can search this file https://github.com/obophenotype/upheno-dev/blob/master/src/curation/upheno-config.yaml for |
Ok, the |
for this not to produce false positives like DDPHENO:0000004 decreased migratory slug size (DDPHENO) skos:exactMatch DDPHENO:0000379 decreased vegetative cell size (DDPHENO) semapv:LexicalMatching oaklib 0.9411764705882353 oio:hasDbXref oio:hasDbXref pmid:18366659 we need the phenotype ontologies to follow standards and not use pmids as class xrefs this may take a while to percolate, so should we filter at the robot level or the oak level? |
I opened a parallel PR by accident. Sorry Nico! |
@cmungall i am happy to lead a push on cleaning out these xrefs, but first we need to answer this: information-artifact-ontology/ontology-metadata#94 |