Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeo unroll Goal is Extremely Slow #834

Open
volodya-lombrozo opened this issue Nov 5, 2024 · 5 comments
Open

Jeo unroll Goal is Extremely Slow #834

volodya-lombrozo opened this issue Nov 5, 2024 · 5 comments
Assignees
Labels
blocked This issue is blocked by some other issue bug Something isn't working

Comments

@volodya-lombrozo
Copy link
Member

According with this benchmark, the unroll goal takes around 100 sec which is rather slow:

Input: com/sun/jna/Pointer.class
Size of .class: 22Kb (22Kb bytes)
Size of .xmir after disassemble: 1Mb (1Mb bytes, 27883 lines)
Size of .phi: 2Mb (2Mb bytes, 42165 lines)
Size of .xmir after unphi: 6Mb (6Mb bytes, 156806 lines)
Optimization time: 3min (207525 ms)

jeo-maven-plugin:unroll-phi   107.458
eo-maven-plugin:xmir-to-phi   81.540
eo-maven-plugin:phi-to-xmir   11.599
jeo-maven-plugin:disassemble  2.025
exec-maven-plugin:exec        0.985
jeo-maven-plugin:assemble     0.634

It's worth optimizing it.

@volodya-lombrozo
Copy link
Member Author

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you help here, please?

@volodya-lombrozo volodya-lombrozo added the bug Something isn't working label Nov 5, 2024
@yegor256
Copy link
Member

yegor256 commented Nov 5, 2024

@volodya-lombrozo there are a few XSL files that are copy-pasted from eo-parser module. Maybe you can make this module a dependency and use these files from the module? This will help, since we already optimized the performance of them in the EO project, for example add-refs.xsl (here).

@volodya-lombrozo volodya-lombrozo self-assigned this Nov 8, 2024
@volodya-lombrozo volodya-lombrozo added the soon This issue will be solved soon label Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 8, 2024
@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you try the new 0.6.16 version please? It should speed up unroll goal a bit.

volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 11, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 12, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 12, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 12, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 12, 2024
@volodya-lombrozo
Copy link
Member Author

Unroll goal depends on eo transformations mostly. All the performance problems arise from ineffective xslt transformations. When they will be optimised, we can continue with this issue.
You can track the progress here: objectionary/eo#3490

@volodya-lombrozo volodya-lombrozo added blocked This issue is blocked by some other issue and removed soon This issue will be solved soon labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by some other issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants