Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#834): Run 'unroll' In Parallel #852

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Nov 8, 2024

In this PR I made UnrollMojo work in parallel. It significantly speeds up the entire goal.
For example, for phi-unphi integration test we got the following results:

Before (sequentially): 10s, 9s, 8s
After (with parallelism): 4s, 5s, 4s

Related to #834.


PR-Codex overview

This PR focuses on enhancing the UnrollMojo and Unroller classes to improve the handling of PHI/UNPHI transformations, including logging improvements and adding new test classes. It also introduces a new dependency on Saxon-HE for XML transformations.

Detailed summary

  • Added net.sf.saxon.TransformerFactoryImpl to the META-INF/services/javax.xml.transform.TransformerFactory.
  • Introduced Saxon-HE dependency in pom.xml.
  • Enhanced UnrollMojo with logging for transformation counts and execution time.
  • Modified Unroller:
    • Changed constructor and method visibility from public to package-private.
    • Renamed unroll() method to return the count of unrolled files.
    • Added prepareThread() method for setting class loader properties.
  • Created new classes A, B, C, and D in src/it/phi-unphi/src/main/java/org/eolang/hone/mess for testing purposes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 8, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit bc590ca into objectionary:master Nov 8, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 8, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 11min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants