Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#834): Add Logging And Improve Unroll #859

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Nov 12, 2024

In this PR I seed up the add-refs.xsl transformation and, what is the most important, I added helpful logging that shows all the hotspots.

Related to #834.


PR-Codex overview

This PR enhances the CanonicalXmir class by adding logging for the parsing process and modifies the add-refs.xsl stylesheet to include new functions for handling XML nodes, improving error messages, and adding a key for node referencing.

Detailed summary

  • Added logging in the parse method of CanonicalXmir to track parsing time.
  • Introduced a new xsl:key named o-by-name in add-refs.xsl.
  • Modified the match condition in the with-base template to exclude base attributes starting with '.'.
  • Improved error messaging for duplicate names and missing @line attributes.
  • Added three new functions: eo:closest, eo:has-intersecting-route, and eo:get-route for better node handling in the XSLT.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 12, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 0bed016 into objectionary:master Nov 12, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 12, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 16min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants