Reduce code duplication down to 15 lines per piece #2916
Conversation
… UnplaceMojoTest
|
@c71n93 what's up with this one? Still a draft? |
|
@yegor256 still working on it |
c71n93
force-pushed
the
2863-reduce-code-duplication-15
branch
from
a2dd750 to
74c589c
Compare
|
@maxonfjvipon could you check this one, please? Pay attention to |
|
@c71n93 when one part of the methods is placed inside abstract class and other part is placed inside concrete class - it's a marker of bad design. If we're not talking about corner cases like mojos, the only right usage of abstract classes is decorating envelopes: https://www.yegor256.com/2017/01/31/decorating-envelopes.html |
|
@c71n93 what's up with this one? |
|
@maxonfjvipon what do you think about |
|
@maxonfjvipon all resolved, could you review this one, please? |
| @@ -86,25 +86,6 @@ public void usesCatcherOutput() { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
@c71n93 why was this test removed?
There was a problem hiding this comment.
there was 2 same tests with different names
| * The data is saved to a file. | ||
| * @since 0.32.0 | ||
| */ | ||
| public interface DataSaved { |
There was a problem hiding this comment.
@c71n93 interface with default methods - it's almost the same as abstract class. You split the logic and keep it in different places.
|
@maxonfjvipon could you check this one again, please? |
|
@yegor256 could you check this one, please? |
|
@rultor merge |
Related to #2863
PR-Codex overview
This PR updates Java versions, refactors saving logic, and improves test parameterization.
Detailed summary
HmOptionalandHmBaseUnplaceMojoTest