Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce code duplication to 15 lines per piece #2863

Closed
yegor256 opened this issue Feb 6, 2024 · 3 comments
Closed

reduce code duplication to 15 lines per piece #2863

yegor256 opened this issue Feb 6, 2024 · 3 comments
Labels
bug help wanted

Comments

@yegor256
Copy link
Member

yegor256 commented Feb 6, 2024

We decreased it to 25 in #2859

See this line: https://github.com/objectionary/eo/blob/fd123092cd18caa5fffc730a9b911fbfddc83db9/.github/workflows/simian.yml#L27C39-L27C39 Let's decrease the --threshold down to 15
@yegor256
Copy link
Member Author

@c71n93 maybe you can help with this one?

@c71n93
Copy link
Member

c71n93 commented Mar 4, 2024

@yegor256 yeah, I will take it

c71n93 added a commit to c71n93/eo that referenced this issue Mar 4, 2024
@c71n93
objectionary#2863 add extra object to reduce code duplication
72632f2
@c71n93 c71n93 mentioned this issue Mar 4, 2024
Merged
c71n93 added a commit to c71n93/eo that referenced this issue Mar 4, 2024
@c71n93
objectionary#2863 make Home abstract class to reduce code duplication
4e872b4
c71n93 added a commit to c71n93/eo that referenced this issue Mar 4, 2024
@c71n93
objectionary#2863 create extra function to reduce code duplication in…
67606b9 
… UnplaceMojoTest
c71n93 added a commit to c71n93/eo that referenced this issue Mar 4, 2024
@c71n93
objectionary#2863 get rid of ugly method using parametrized test
34f68ad
c71n93 added a commit to c71n93/eo that referenced this issue Mar 4, 2024
@c71n93
objectionary#2863 supress UnusedPrivateMethod warning
31572d1
c71n93 added a commit to c71n93/eo that referenced this issue Mar 5, 2024
@c71n93
objectionary#2863 replace anonymous class by single implementation to…
85ce4c3 
… reduce code duplicatoin
@c71n93 c71n93 mentioned this issue Mar 5, 2024
Merged
c71n93 added a commit to c71n93/eo that referenced this issue Mar 5, 2024
@c71n93
objectionary#2863 fix qulice warnings
333e32f
c71n93 added a commit to c71n93/eo that referenced this issue Mar 5, 2024
@c71n93
objectionary#2863 create additional object for test to reduce code du…
153aeb9 
…plication
c71n93 added a commit to c71n93/eo that referenced this issue Mar 8, 2024
@c71n93
objectionary#2863 add PhDecorator abstract class to reduce code dupli…
0a6fa6f 
…cation
c71n93 added a commit to c71n93/eo that referenced this issue Mar 8, 2024
@c71n93
objectionary#2863 delete some unnecessary methods overriding
adee12e
c71n93 added a commit to c71n93/eo that referenced this issue Mar 8, 2024
@c71n93
objectionary#2863 use dirty hacks to reduce code duplication
3be2745
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 fix documentation
0d5bbfb
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 fix documentation again
80f0434
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 slightly change the message[C
54c603b
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 slightly change the message
9f46272
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 slightly change the messages
6b317f8
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 fix qulice violations
a2dd750
c71n93 added a commit to c71n93/eo that referenced this issue Mar 11, 2024
@c71n93
objectionary#2863 fix qulice warnings
74c589c
c71n93 added a commit to c71n93/eo that referenced this issue Mar 27, 2024
@c71n93
objectionary#2863 remove unnecessary test
03e7d15
c71n93 added a commit to c71n93/eo that referenced this issue Apr 11, 2024
@c71n93
objectionary#2863 remove duplicated test
8b58618
c71n93 added a commit to c71n93/eo that referenced this issue Apr 11, 2024
@c71n93
objectionary#2863 remove sudden groovy libs
5be5468
c71n93 added a commit to c71n93/eo that referenced this issue Apr 11, 2024
@c71n93
objectionary#2863 new line at the end of the file
cc49278
c71n93 added a commit to c71n93/eo that referenced this issue Apr 15, 2024
@c71n93
objectionary#2863 get rid of Home abstract class
76f06cd
c71n93 added a commit to c71n93/eo that referenced this issue Apr 15, 2024
@c71n93
objectionary#2863 rollback to current master
725d9b1
c71n93 added a commit to c71n93/eo that referenced this issue Apr 15, 2024
@c71n93
objectionary#2863 remove PhDecorator
daaee28
c71n93 added a commit to c71n93/eo that referenced this issue Apr 15, 2024
@c71n93
objectionary#2863 remove newline at the end of file
c73be94
c71n93 added a commit to c71n93/eo that referenced this issue May 2, 2024
@c71n93
objectionary#2863 try to get rid of default methods in Home interface
9a959ae
c71n93 added a commit to c71n93/eo that referenced this issue May 2, 2024
@c71n93
objectionary#2863 fix namings and qulice violations
3258acd
c71n93 added a commit to c71n93/eo that referenced this issue May 2, 2024
@c71n93
objectionary#2863 fix threshold
e422a9c
@c71n93
Copy link
Member

c71n93 commented May 6, 2024 •
edited
Loading

@yegor256 we can close this one now (done in #2916)

@yegor256 yegor256 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yegor256 @c71n93