Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for pre-defined rules #9

Merged
merged 26 commits into from
Jan 13, 2024
Merged

Add initial support for pre-defined rules #9

merged 26 commits into from
Jan 13, 2024

Conversation

aabounegm
Copy link
Collaborator

@aabounegm aabounegm commented Dec 25, 2023

This pull request adds the foundation for further development by doing the following:

One issue identified with rule 1 is that it treats the top-level program as an object and adds ν to it.


PR-Codex overview

Focus of this PR

This PR focuses on adding new rules and improving the normalization process in the EO Phi language.

Detailed summary

  • Added new rules for object formation and dispatch.
  • Improved the normalization process for objects.
  • Updated the syntax and print functions for object head and action.
  • Added unit tests for the new rules.
  • Made the project compile with -Werror flag.

The following files were skipped due to too many changes: eo-phi-normalizer/src/Language/EO/Phi/Rules/Common.hs, eo-phi-normalizer/src/Language/EO/Phi.hs, eo-phi-normalizer/src/Language/EO/Phi/Normalize.hs, eo-phi-normalizer/src/Language/EO/Phi/Syntax.hs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@deemp
Copy link
Member

deemp commented Dec 27, 2023

Pls, rebase on master as #7 is merged

aabounegm and others added 6 commits December 29, 2023 00:49
using State monad to keep track of total Nu count

Co-authored-by: Danila Danko <[email protected]>
So that state would be preserved across its bindings

Co-authored-by: Danila Danko <[email protected]>
@aabounegm aabounegm marked this pull request as ready for review December 28, 2023 22:32
@deemp deemp requested a review from fizruk December 28, 2023 22:38
@aabounegm aabounegm mentioned this pull request Jan 10, 2024
@fizruk
Copy link
Collaborator

fizruk commented Jan 11, 2024

The latest changes introduce a simple nondeterministic rewriting for any given rule set (encoded in Haskell) and rule 6 as example.

@deemp deemp changed the title Rule 1 Add initial support for pre-defined rules Jan 11, 2024
@deemp deemp requested a review from fizruk January 12, 2024 14:46
@fizruk fizruk merged commit b43f6e3 into master Jan 13, 2024
4 checks passed
@aabounegm aabounegm deleted the rule-1 branch January 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants