Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grammar #22

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix grammar #22

merged 2 commits into from
Jan 11, 2024

Conversation

deemp
Copy link
Member

@deemp deemp commented Jan 10, 2024 •
edited by pr-codex bot
Loading

Closes #21

PR-Codex overview

The focus of this PR is to update the BNF Converter generated files in the eo-phi-normalizer project.

Detailed summary

  • Updated the Bytes token definition in Par.y and Lex.x files.
  • Updated the Function token definition in Lex.x file.
  • Updated the literals and reserved words in Doc.txt file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@deemp deemp linked an issue Jan 10, 2024 that may be closed by this pull request
Fix grammar #21
Closed
1 task
@deemp deemp requested review from aabounegm and fizruk January 10, 2024 00:26
@deemp deemp mentioned this pull request Jan 10, 2024
Closed
@aabounegm
Copy link
Collaborator

This has already been fixed in 9f4c9ac, but #9 is not merged yet. If we do not plan on merging it soon, I suggest creating another branch at that specific commit and merging it instead to avoid conflicts

@aabounegm aabounegm mentioned this pull request Jan 10, 2024
Merged
@deemp
Copy link
Member Author

deemp commented Jan 10, 2024 •
edited
Loading

That fix was partially incorrect. See 9f4c9ac#r136677204

In case it's gone

image

@fizruk fizruk merged commit 5025451 into master Jan 11, 2024
4 checks passed
@fizruk fizruk deleted the 21-fix-grammar branch January 11, 2024 07:11
@aabounegm aabounegm mentioned this pull request Jan 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk fizruk approved these changes

@aabounegm aabounegm Awaiting requested review from aabounegm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix grammar
4 participants
@deemp @aabounegm @fizruk @0pdd