Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the rule conversion leaves no metavariables #88

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Ensure the rule conversion leaves no metavariables #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db66b17
Ensure the rule conversion leaves no metavariables
aabounegm Feb 2, 2024
6df26b0
Expand the wildcard to make all matches explicit
aabounegm Feb 2, 2024
8ee2c39
Reorder branches to match the order in syntax file
aabounegm Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion eo-phi-normalizer/src/Language/EO/Phi/Rules/Yaml.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,34 @@ convertRule Rule{..} ctx obj =
| subst <- matchObject pattern obj
, all (\cond -> checkCond ctx cond subst) when
, obj' <- [applySubst subst result]
-- TODO #82:20m check that obj' does not have any metavariables
, not (objectHasMetavars obj')
]

objectHasMetavars :: Object -> Bool
objectHasMetavars (Formation bindings) = any bindingHasMetavars bindings
objectHasMetavars (Application object bindings) = objectHasMetavars object || any bindingHasMetavars bindings
objectHasMetavars (ObjectDispatch object attr) = objectHasMetavars object || attrHasMetavars attr
objectHasMetavars (GlobalDispatch attr) = attrHasMetavars attr
objectHasMetavars (ThisDispatch attr) = attrHasMetavars attr
objectHasMetavars Termination = False
objectHasMetavars (MetaObject _) = True

bindingHasMetavars :: Binding -> Bool
bindingHasMetavars (AlphaBinding attr obj) = attrHasMetavars attr || objectHasMetavars obj
bindingHasMetavars (EmptyBinding attr) = attrHasMetavars attr
bindingHasMetavars (DeltaBinding _) = False
bindingHasMetavars (LambdaBinding _) = False
bindingHasMetavars (MetaBindings _) = True

attrHasMetavars :: Attribute -> Bool
attrHasMetavars Phi = False
attrHasMetavars Rho = False
attrHasMetavars Sigma = False
attrHasMetavars VTX = False
attrHasMetavars (Label _) = False
attrHasMetavars (Alpha _) = False
attrHasMetavars (MetaAttr _) = True

-- | Given a condition, and a substition from object matching
-- tells whether the condition matches the object
checkCond :: Common.Context -> Condition -> Subst -> Bool
Expand Down