Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template for 'administration of substance in vivo' terms #1706

Merged
merged 15 commits into from
Nov 30, 2023

Conversation

sebastianduesing
Copy link
Contributor

Closes issue #1703. Creating a template (administration.tsv) for subclasses of 'administration of substance in vivo' to standardize the design pattern for terms including the route-of-administration terms requested in issue #1703 for IEDB.

Committing after initial make imports
Added relevant Uberon anatomy terms
Adds ROBOT template (administration.tsv) for administration of substance in vivo branch.
Simplified the logical axioms of administration.tsv as per conversation on 06.05.2023 OBI dev call.
@sebastianduesing sebastianduesing linked an issue Jul 5, 2023 that may be closed by this pull request
@sebastianduesing
Copy link
Contributor Author

I've added a few commits in which I've moved some existing administration-branch terms to the administration template. Here's a link to a ROBOT diff between the existing version (with the current terms in obi-edit) and the proposed version (with those terms in the administration module). I've included some annotations/comments about the changes made; almost all changes to logic have to do with getting rid of redundant class axioms that are already inherited from a parent class. I'm happy to talk through this on an OBI call.

Adds "disease causation objective," "disease prevalence reduction objective," "disease severity reduction objective," and "disease prevention objective" to the objective column of relevant terms.
@sebastianduesing
Copy link
Contributor Author

This is ready for final review & merging. To be discussed in next OBI dev call.

@jamesaoverton jamesaoverton merged commit dc92eba into master Nov 30, 2023
1 check passed
@jamesaoverton jamesaoverton deleted the administration_1703 branch November 30, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR: routes of administration
2 participants