Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated github action to use java 8 #86

Closed
wants to merge 11 commits into from
Closed

Updated github action to use java 8 #86

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ce2570d
Updated github action to use java 8
nylonee Jan 31, 2024
1e54576
to revert - test this in PR
nylonee Jan 31, 2024
142fa49
try the 1.3 version of logback
nylonee Jan 31, 2024
b10637b
parallel release
nylonee Jan 31, 2024
c450838
Java 8 test
nylonee Jan 31, 2024
54fe51d
building a fat jar should fail
nylonee Feb 1, 2024
7ca4e77
readme update, plus revert build.sbt
nylonee Feb 1, 2024
cd35192
try lower logback
nylonee Feb 11, 2024
b6b59b3
revert
nylonee Feb 11, 2024
af339e9
hot-switch logging implementation
nylonee Feb 11, 2024
c5ad7b5
this
nylonee Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/release-java-8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Test Java 8

on:
pull_request:
branches: [ "main" ]

permissions:
contents: write

jobs:

build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Set up JDK 8
uses: actions/setup-java@v3
with:
java-version: '8'
distribution: 'temurin'
cache: 'sbt'
- name: sbt validation
run: sbt "dependencyUpdatesFailBuild; unusedCompileDependenciesTest; undeclaredCompileDependenciesTest; test"
- name: Build fat JAR
run: sbt assembly
Comment on lines +1 to +27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the workflow name accurately reflects its purpose, especially since it's not only testing but also building a fat JAR. Consider renaming it to more accurately describe its full scope, e.g., "Build and Test with Java 8".

Comment on lines +25 to +27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command in the "Build fat JAR" step might benefit from specifying the project or module if the repository contains multiple sbt projects. This ensures clarity and prevents potential issues when building the JAR.

1 change: 0 additions & 1 deletion .github/workflows/release-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
- name: sbt validation
run: sbt "dependencyUpdatesFailBuild; unusedCompileDependenciesTest; undeclaredCompileDependenciesTest; test"
- name: Build fat JAR
if: startsWith(github.ref, 'refs/tags/')
run: sbt assembly
- name: Rename fat JAR
if: startsWith(github.ref, 'refs/tags/')
Comment on lines 28 to 33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-29]

The workflow still sets up JDK 11, which contradicts the PR's objective to align development with Java 8. If the intention is to maintain both Java 8 and Java 11 environments, clarify this in the documentation to avoid confusion.

Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ val circeGenericExtrasVersion = "0.14.3"
val circeVersion = "0.14.6"
val fs2Version = "3.7.0"
val http4sVersion = "0.23.23"
val logbackVersion = "1.4.11"
val logbackVersion = "1.3.11"
val scalamockVersion = "5.2.0"
val scalatestVersion = "3.2.17"
val shapelessVersion = "2.3.10"
Expand Down
Loading