Skip to content

Commit

Permalink
fix(get): migrate from unzipper to yauzl-promise to prevent corru…
Browse files Browse the repository at this point in the history
…pting files (#1015)

### Description of Changes

- Migrate from `unzipper` to `yauzl-promise`
- Remove Node 14 from test matrix

Notes: Unzipping MacOS build on MacOS platform fails with `End of
Central Directory Record not found` error message. Will look at it in
another PR to prevent scope creep.

Fixes: #1002
Closes: #1000
  • Loading branch information
ayushmanchhabra authored Jan 23, 2024
1 parent b06f052 commit 673985e
Show file tree
Hide file tree
Showing 6 changed files with 549 additions and 176 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [macos-13, ubuntu-22.04, windows-2022]
node: [14, 16, 18, 20, 21]
node: [16, 18, 20, 21]
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down
Loading

0 comments on commit 673985e

Please sign in to comment.