Skip to content

Commit

Permalink
chore(node:test): migrate to vitest (#1014)
Browse files Browse the repository at this point in the history
### Description of Changes

- Migrate to Vitest
- Add Node 14 to testing matrix

Notes: Tests fail since downloads take reallt long but setting timeout
to infinity does not work. This is likely due to a race condition
somewhere in the codebase where a promise is not resolving.
  • Loading branch information
ayushmanchhabra authored Jan 22, 2024
1 parent 0119cb8 commit b06f052
Show file tree
Hide file tree
Showing 12 changed files with 1,396 additions and 128 deletions.
10 changes: 8 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Fixes: #
### Description of Changes

## Description
- ...

<!-- Notes: additional context on why this PR is being merged when it doesn't seem like it should -->

<!-- Fixes: # -->
<!-- Closes: # -->
<!-- Refs: # -->
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [macos-13, ubuntu-22.04, windows-2022]
node: [16, 18, 20, 21]
node: [14, 16, 18, 20, 21]
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ Options
| logLevel | `"error" \| "warn" \| "info" \| "debug"` | `"info"`| Specify level of logging. |
| zip | `boolean \| "zip" \| "tar" \| "tgz"` | `false`| If true, "zip", "tar" or "tgz" the `outDir` directory is compressed. |


## Guides

### Get unofficial MacOS builds
Expand Down Expand Up @@ -274,8 +273,8 @@ nwbuild({

### Bugs

- https://github.com/nwutils/nw-builder/issues/1000
- https://github.com/nwutils/nw-builder/issues/1002
- <https://github.com/nwutils/nw-builder/issues/1000>
- <https://github.com/nwutils/nw-builder/issues/1002>
- Add back error, info and debug logs

### Features
Expand All @@ -294,7 +293,6 @@ nwbuild({
- chore(cicd): use `google-github-actions/release-please-action` to automate publishing to npm, updating changelog and creating releases
- chore(test): add test cases for current features
- chore(yargs): migrate to `commander`
- chore(node:test): migrate to `vitest`
- chore(unzipper): migrate to `yauzl-promise`
- chore(util): factor out nw file paths finder
- chore(get): factor out https downloader
Expand Down
Loading

0 comments on commit b06f052

Please sign in to comment.