Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #82 and #84 #85

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Fix for #82 and #84 #85

merged 3 commits into from
Aug 28, 2023

Conversation

elv1s42
Copy link
Contributor

@elv1s42 elv1s42 commented Jun 13, 2023

This is a simple fix for #82 and #84
The idea is that we don't need to use the test name when creating a directory for the artifact. In any case, such artifacts are published into a hidden folder .teamcity/NUnit/, so it is enough to use just Guid.NewGuid() instead of using trimmed test name with escaped special characters.

@NikolayPianikov
Copy link
Member

@elv1s42 Thanks for the PR. Give me time to analyze the implications in terms of backwards compatibility.

@elv1s42
Copy link
Contributor Author

elv1s42 commented Aug 8, 2023

@NikolayPianikov, any updates on this please?

@k15tfu
Copy link

k15tfu commented Aug 18, 2023

Friendly ping.

@hn100823
Copy link

hn100823 commented Aug 23, 2023

Hope that this could be completed soon

@NikolayPianikov NikolayPianikov merged commit 3b18547 into nunit:master Aug 28, 2023
@NikolayPianikov
Copy link
Member

Sorry for the delay. My GitHub account was suspended for a while.

@hn100823
Copy link

hi @NikolayPianikov may I ask when will we have the new release for this?
As I see here
https://www.nuget.org/packages/NUnit.Extension.TeamCityEventListener
The latest version is 1.0.7 from 2019
Will this be included in the newer version of Nunit (which version)
or do we have to install it separately?

@hn100823
Copy link

hn100823 commented Sep 5, 2023

hi @NikolayPianikov When will the next releases of this project/issue? and When that be included in a release of the NUnit console?

@NikolayPianikov
Copy link
Member

NikolayPianikov commented Sep 7, 2023

@hn100823 I plan to do it within a week. Yes, you will have to add the package manually until the NUnit.Console package is released

@hn100823
Copy link

hi @NikolayPianikov, as I see the latest release is from 2019
https://github.com/nunit/teamcity-event-listener/releases
Is there any issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants