Merge pull request #85 from elv1s42/master

Fix for #82 and #84
nunit · Aug 28, 2023 · 3b18547 · 3b18547
2 parents 362343d + 2f78ad4
commit 3b18547
Showing 1 changed file with 2 additions and 35 deletions.
diff --git a/src/extension/ServiceMessageFactory.cs b/src/extension/ServiceMessageFactory.cs
@@ -16,29 +16,7 @@ internal class ServiceMessageFactory : IServiceMessageFactory
  private const string TcParseServiceMessagesInside = "tc:parseServiceMessagesInside";
  private static readonly IEnumerable<ServiceMessage> EmptyServiceMessages = new ServiceMessage[0];
  private static readonly Regex AttachmentDescriptionRegex = new Regex("(.*)=>(.+)", RegexOptions.Compiled);
- private static readonly List<char> _invalidChars;
-
- static ServiceMessageFactory()
- {
- var invalidPathChars = Path.GetInvalidPathChars();
- var invalidFileNameChars = Path.GetInvalidFileNameChars();
- _invalidChars = new List<char>(invalidPathChars.Length + invalidFileNameChars.Length);
- foreach (var c in invalidPathChars)
- {
- _invalidChars.Add(c);
- }
-
- foreach (var c in invalidFileNameChars)
- {
- if (_invalidChars.Contains(c))
- {
- continue;
- }
-
- _invalidChars.Add(c);
- }
- }
-
+
  public ServiceMessageFactory(ITeamCityInfo teamCityInfo, ISuiteNameReplacer suiteNameReplacer)
  {
  _teamCityInfo = teamCityInfo;
@@ -382,18 +360,7 @@ private static IEnumerable<ServiceMessage> Attachments(EventId eventId, XmlNode
 
  if (artifactDir == null)
  {
- var testDirNameChars = new char[eventId.FullName.Length];
- eventId.FullName.CopyTo(0, testDirNameChars, 0, eventId.FullName.Length);
- for (var i = 0; i < testDirNameChars.Length; i++)
- {
- if (_invalidChars.Contains(testDirNameChars[i]))
- {
- testDirNameChars[i] = '_';
- }
- }
-
- var testDirName = new string(testDirNameChars);
- artifactDir = ".teamcity/NUnit/" + testDirName + "/" + Guid.NewGuid();
+ artifactDir = ".teamcity/NUnit/" + Guid.NewGuid();
  }
 
  string artifactType;