-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Poll] Comment Color Brightness #94
Comments
Has there been any updates on this? |
@Alby407 This is still an important topic (issue has also been pinned), but there are still some more important tasks like the documentation and assets transition to Nord Docs. As soon as |
This is really a massive issue in my book. It's a big usability issue. |
The original design decision was to help the user to focus on the code while metadata stays out of the way. I decided to increase the priority (see edited comment above) and will start to implement the changes as of today. The order will be the same like the order on the ports page which is sorted by GitHub stars. This reflects which ports are used the most so these will need to be updated first. |
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. This change also deprecates the comment contrast (1) configuration. It is not necessary anymore for users to increase the brightness on their own when the default color has been increased by default. A deprecation warning will be shown to notify all users who have set a custom value for the `g:nord_comment_brightness` configuration variable. References: (1) https://github.com/arcticicestudio/nord-vim#comment-contrast GH-145
The implementation for Nord Vim is completed and has been 🚀 deployed in release version 🏷 0.10.0 |
@arcticicestudio for ports without this feature (gnome-terminal, gedit, etc), would changing |
@duhok1 Ports for any terminal, like e.g. GNOME Terminal, won't be changed at all since they are not responsible for syntax highlighting.All they do is providing the value for the color that stands for the available colors 0-15.
Terminal ports have nothing but the colors while the highlighting is handled by the app that runs within the terminal like Vim or Emacs. The color for such ports like Vim and EMacs will be adjusted since they are providing a explicit definition for comments. |
-> Please see nordtheme/nord#94 (1) for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. References: (1) nordtheme/nord#94 GH-117
The implementation for Nord Visual Studio Code is completed and has been 🚀 deployed in release version 🏷 0.8.0 |
-> Please see nordtheme/nord#94 (1) for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. References: (1) nordtheme/nord#94 GH-41
The implementation for Nord Jetbrains Editor is completed and has been 🚀 deployed in release version 🏷 0.4.0 |
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. This change also deprecates the custom comment brightness (1) configuration. It is not necessary anymore for users to increase the brightness on their own when the default color has been increased by default. A deprecation/obsolete warning will be shown to notify all users who have set a custom value for the `g:nord_comment_brightness` configuration variable. References: (1) https://github.com/arcticicestudio/nord-emacs#custom-comment-brightness GH-73
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. This change also deprecates the "Custom Comment Contrast" theme setting. It is not necessary anymore for users to increase the brightness on their own when the default color has been increased by default. A deprecation warning will be shown to notify all users who have set a custom value for the configuration variable. GH-60
The implementation for Nord Emacs is completed and has been 🚀 deployed in release version 🏷 0.4.0 |
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. GH-6
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. GH-10
Why don't you check contrast with a tool such as colorable? I'm using the latest version of the highlight nord theme and the comment color still has very poor contrast |
This repository “only“ contains the colors and palettes of Nord while each port lives in its own repository.
…the sources in this repository won't change at all. Since this issue is still open there are still ports that require this change so maybe that's why you're still seeing the original Regarding calculated colors with tools like colorable:
Don't get me wrong here: This issue only exists because By the way, the link you posted uses |
Thanks a lot for your reply. I really like Nord and was actually thinking about adapting my website colors to it. I use Textmate as my text editor and found this port, which doesn't have that color change for sure. It just struck me that the comment color had so poor contrast (also when using the Thanks again, looking forward for documentation updates and hopefully one for adapting websites to it 😉. |
I also think that such tools are great when it comes to supporting accessibility, but there are also use cases when they are not necessary or at least you don't have to base your action entirely on it like in this case the overall “authentic appearance“ of a theme. I also hold on to my opinion because there are “limits“ when it comes to accessibility for themes like syntax highlighting, e.g. a person with severely impaired eyesight would never actually search for “authentic“ themes but instead make sure that there is a “high contrast“ mode or theme instead. Such persons wouldn't really mind about nice colors and themes like Nord are not a option for them at all. Also the progress for port projects in this issue is of course only scoped to official ports while the one you linked is a community created project. I've quickly imported the theme into the TM editor web app and it looks like the You're absolutely right about Nords documentations, the brightened color is currently not mentioned at all in the the paragraph about |
Hi this discussion predates my using nord-theme. However, I'd like to share my personal settings for comments and emacs-lisp documentation strings. I'm using 'tan' for comments and a dark cyan for the documentation strings because the dim grayish colours used by default hide comments too much. For me they are an essential part of code and I need them ;-) A small screenshot: Best, /PA |
I think this issue should be closed. The new brightness is implemented in all syntax/editor projects. The only thing left is to update the docs about |
Prehistory
There have been many contributions and issues about the comment color brightness across almost all port projects related to the current comment color and its brightness. Many users explained that it is hard to recognize and read comments.
Current Situation
The low contrast color for comment is by design of Nord and has been selected specifically to not disturb code flow and keep the focus of the developer on the code, but there are indeed situations where this design can also turn to a problem:
Another aspect users disagree with the highlighting color assignments is that everyone has different preferences. That's fine of course, and the reason why themes exist 😄
Existing Workarounds
Due to the high amount of requests the decision has been made to implement a theme configuration for all port projects with support for such theme mechanisms. Unfortunately not all port projects were able to provide this option due to limitations of the targeting application/platform.
The configuration allows users to define a custom comment color brightness with percentage adjustments from 0 - 20. It is a way to provide a way for users to easily adjust the comment color to fit their needs without overriding specific code parts individually. To adhere to the Nord style guide the initial value has been set to use nord3 by default and applied as fallback when the user assigned a invalid value.
This customization has been first implemented to the Nord Atom Syntax project and then ported to other port projects like e.g. Nord Vim and Nord Emacs. The values are calculated using the Sass
lighten
function to ensure full interoperability with other port projects that providing this theme feature. The lightness was calculated using thelightness
function.To help users to choose a new comment color and provide a overview of the new available values a table has been added to the documentations:
nord3
#4e586d
#505b70
#525d73
#556076
#576279
#59647c
#5b677f
#5d6982
#5f6c85
#616e88
#63718b
#66738e
#687591
#6a7894
#6d7a96
#6f7d98
#72809a
#75829c
#78859e
#7b88a1
Click to show Sass code used to calculate the new increased brightness values
Current Situation
I've increased the comment color by 5% up to 8% locally for all my port projects I use every day and finally came to the decision that it should be fine to increase the current comment color by default. It has been requested in many port projects and I'd like to listen to the community to make the theme even more comfortable 🚀
Note that this will not affect Nord itself, the color palette won't change. It'll be changed in the documentation and style guidelines and only adjusted for port projects that define syntactic rules for comments. nord3 is good as it is and still works fine for all UI projects!
Also, each port project that has the capability to provide the theme configuration (like Nord Atom Syntax & UI, Nord Vim) will eventually get some kind of legacy comment color mode to not break the theme for users that like the current comment color.
Your Opinion Counts
This poll issue has been to get feedback from the community and users of all port projects to decide the value which will be between 5 and 8 percent.
Please vote only once for the value you'd like to see the comment color to be increased by!
With
nord3
(default)Increased by 10%
Journals
2019-03-17
Thanks everyone for your votes! 🏆
And the winner is… 8%!
This result clearly shows that the community want to increase the comment brightness significantly. Therefore the used value won't be 8 but 10 percent. The decision is based on the facts that it provides a lightness level of ~45.7% instead of ~43.7% which more than 24% higher than the level of the base background color
nord0
. It also improves the visual dissociation tonord1
andnord2
that are used as selection and active line background colors.On the other side a higher increase value would collide with often used colors like
nord9
(keywords, flow control statements, operators etc.). Their brightness level (~63.14%) and saturation would be too equal making it hard to distinguish between the two colors.Please see the implementation status section below to get an overview of the actual change progress for each port project.
Implementation Status
The order for the port project implementations is the same like the order on the ports page which is sorted by GitHub stars. This reflects which ports are used the most so these will need to be updated first.
Nord Vim
All implementation details and requirements are documented in the corresponding issue nordtheme/vim#145.
Nord Visual Studio Code
All implementation details and requirements are documented in the corresponding issue nordtheme/visual-studio-code#117 and PR nordtheme/visual-studio-code#118.
Nord Jetbrains Editor
All implementation details and requirements are documented in the corresponding issue nordtheme/jetbrains#41 and PR nordtheme/jetbrains#42.
Nord Emacs
All implementation details and requirements are documented in the corresponding issue nordtheme/emacs#73 and PR nordtheme/emacs#74.
Nord Gedit
All implementation details and requirements are documented in the corresponding issue nordtheme/gedit#13 and PR nordtheme/gedit#14.
Nord Atom Syntax
All implementation details and requirements are documented in the corresponding issue nordtheme/atom-syntax#60 and PR nordtheme/atom-syntax#61.
Nord Sublime Text
All implementation details and requirements are documented in the corresponding issue nordtheme/sublime-text#18 and PR nordtheme/sublime-text#19.
Nord Xcode
All implementation details and requirements are documented in the corresponding issue nordtheme/xcode#6 and PR nordtheme/xcode#7.
Nord highlight.js
All implementation details and requirements are documented in the corresponding issue nordtheme/highlightjs#10 and PR nordtheme/highlightjs#11.
Nord Notepad++
All implementation details and requirements are documented in the corresponding issue nordtheme/notepadplusplus#5 and PR nordtheme/notepadplusplus#6.
Nord Brackets
All implementation details and requirements are documented in the corresponding issue nordtheme/brackets#6 and PR nordtheme/brackets#7.
Nord Eclipse Syntax
All implementation details and requirements are documented in the corresponding issue nordtheme/eclipse-syntax#6 and PR nordtheme/eclipse-syntax#7.
Nord Coda
All implementation details and requirements are documented in the corresponding issue nordtheme/coda#5 and PR nordtheme/coda#6.
The text was updated successfully, but these errors were encountered: