Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Higher-contrast version #68

Closed
m-thorsen opened this issue May 3, 2018 · 1 comment
Closed

Suggestion: Higher-contrast version #68

m-thorsen opened this issue May 3, 2018 · 1 comment

Comments

@m-thorsen
Copy link

Love the theme, but I had to make a couple of tweaks as I found it a tad too pale for late night sessions.
Not sure how active this project is, but I'll share them here in case you'd like to add an alternative variant.

I'm aware that the darker colors are outside the Nord palette, but I think it looks fairly decent without going overboard (like some forks I've seen).

"workbench.colorCustomizations": {
    "editor.selectionHighlightBackground": "#2e3440",
    "editor.selectionHighlightBorder": "#FFFFFF15",
    "editor.background": "#272c36",
    "editorGutter.background": "#272c36",
    "tab.activeBackground": "#2e3440",
    "tab.inactiveBackground": "#272c36",
    "editorGroupHeader.tabsBackground": "#272c36",
    "editorGroupHeader.tabsBorder": "#2e3440",
    "editorLineNumber.foreground": "#4C566A"
},
"editor.tokenColorCustomizations": {
    "textMateRules": [
        {
            "name": "Comment",
            "scope": "comment",
            "settings": {
                "foreground": "#576279",
                "fontStyle": "italic"
            }
        }
    ]
},

image

@arcticicestudio
Copy link
Contributor

🚀 Thanks for your contribution 👍

This might be interesting for users who'd also like to tweak some parts of the theme to fit their personal preferences. Everyone has different needs and preferences and that's the whole reason why themes exist ;p

Regarding your changes to the comment color: This is a long time requested change in many Nord port projects and that's why there will be official changes. Check out the poll about comment brightness adjustments for more details.

Also, I think you opened this issue because your posted changes would also override other themes. To prevent this VS Code allows you to define overrides scoped for a specific theme by using the theme name like this:

"workbench.colorCustomizations": {
    "[Nord]": {
        // Place your overrides here 
    }
}

This can also be used for syntax theme overrides:

"editor.tokenColorCustomizations": {
    "[Nord]": {
        // Place your overrides here 
    }
},

So, to prevent your customizations from overriding other themes than Nord it should be changed to something similar like this:

  "workbench.colorCustomizations": {
    "[Nord]": {
      "editor.selectionHighlightBackground": "#2e3440",
      "editor.selectionHighlightBorder": "#FFFFFF15",
      "editor.background": "#272c36",
      "editorGutter.background": "#272c36",
      "tab.activeBackground": "#2e3440",
      "tab.inactiveBackground": "#272c36",
      "editorGroupHeader.tabsBackground": "#272c36",
      "editorGroupHeader.tabsBorder": "#2e3440",
      "editorLineNumber.foreground": "#4C566A"
    }
  },
  "editor.tokenColorCustomizations": {
    "[Nord]": {
      "textMateRules": [
        {
          "name": "Comment",
          "scope": "comment",
          "settings": {
            "foreground": "#576279",
            "fontStyle": "italic"
          }
        }
      ]
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants